Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@strega-nil-ms
Copy link
Contributor

fixes #3290

@strega-nil-ms strega-nil-ms added enhancement Something can be improved throughput Must compile faster labels Dec 19, 2022
@strega-nil-ms strega-nil-ms requested a review from a team as a code owner December 19, 2022 23:41
@StephanTLavavej
Copy link
Member

Thanks! I double-checked that none of these removals indicated mistakenly unused code. I also checked whether any further removals were possible - your <variant> change identified a struct whose type wasn't being used at all, and whose _Bools could simply be moved into another struct. I went ahead and pushed that change, as it is also removing an internal identifier, even though the edits aren't purely red.

FYI @CaseyCarter.

@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ab26a21 into microsoft:main Jan 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for noticing and cleaning up this stuff! 🦅 👁️ 🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved throughput Must compile faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused internal identifiers

4 participants