<ranges>: Workaround LLVM-47414
#3328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage will be in the next LLVM update.
take_while_view
take_while_view<ranges>: Workaround LLVM-47414
StephanTLavavej
approved these changes
Jan 10, 2023
Member
|
Looks good! I pushed a couple of commits to guard the workaround concepts as they're needed for Clang only (this applies to pre-existing occurrences too), and to remove more clang-format suppression around these workarounds (being a slightly bad kitty by expanding this PR instead of creating a separate one, but the changes are relatively small/simple, consistent with your other suppression removals, and we've already got a bunch of PRs in flight). |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for consistently working around this compiler bug and finding more clang-format suppressions to remove! All shall love Clang and despair! 😹 😸 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage will be in the next LLVM update.
Drive-by: let clang-format handle some more bits of code.