Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JMazurkiewicz
Copy link
Contributor

Closes #3438.

Drive-by: simplify noexcept specification of slide_view::_Iterator constructor.

@JMazurkiewicz JMazurkiewicz changed the title views::enumerate P2164R9: views::enumerate Feb 15, 2023
@StephanTLavavej StephanTLavavej added cxx23 C++23 feature ranges C++20/23 ranges labels Feb 15, 2023
@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review February 15, 2023 21:49
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 15, 2023 21:49
@JMazurkiewicz

This comment was marked as outdated.

@StephanTLavavej
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

RUNALL_INCLUDE ..\strict_concepts_latest_matrix.lst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change requested, note for other reviewers: Confirmed that strict is necessary.

@StephanTLavavej

This comment was marked as resolved.

@JMazurkiewicz

This comment was marked as outdated.

@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej self-assigned this Feb 24, 2023
@StephanTLavavej
Copy link
Member

I am a greedy kitty who is speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push a fix for my comments

@StephanTLavavej
Copy link
Member

I've pushed a merge with main to fix a trivial adjacent-add conflict in tests/std/test.lst.

@StephanTLavavej StephanTLavavej merged commit 16bb556 into microsoft:main Feb 26, 2023
@StephanTLavavej
Copy link
Member

It would take forever to enumerate my thanks! 😹 ♾️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx23 C++23 feature ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P2164R9 views::enumerate

3 participants