enable asan for all tests #3473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pr wip |
Member
|
This is an admirable idea, but until we find and fix the root cause of #2908, I think that actually enabling such widespread coverage would be cat-astrophic. 😼 |
Contributor
Author
|
Yep, let the PR be blocked for now. |
Member
|
We talked about this at the weekly maintainer meeting - @strega-nil-ms won't have time to investigate the sporadic failure #2908 any time soon, so we're going to close this PR without merging. In the future, when ASAN (hopefully) becomes reliable, we can consider making this change. |
Contributor
|
It seems that #2908 is fixed in upstream. Should we reopen this PR? |
Contributor
Author
|
As I understand no, because Casey's PR was merged: #4052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.