LWG-3847 ranges::to can still return views
#3479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsb4000
reviewed
Feb 18, 2023
fsb4000
reviewed
Feb 18, 2023
fsb4000
reviewed
Feb 18, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
strega-nil-ms
approved these changes
Feb 21, 2023
StephanTLavavej
approved these changes
Feb 22, 2023
Member
|
Thanks! I went ahead and pushed a couple of small fixes to the citations, removing the Working Paper number (as we don't have the patched document yet), and fixing a copy-pasted stable name. FYI @strega-nil-ms as you already approved. Status update for this and your other PR: We merge PRs to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PRs will be part of the next batch this week (very likely soon, we've got a dozen ready). 😸 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Feb 23, 2023
Member
|
Thanks for improving diagnostics for users here, and congratulations on your second microsoft/STL commit! 🐱 😸 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds extra constraints on type_Container that it can't be cv-qualified
Fixes #3417
Note: This is just a best guess attempt at a solution. I'm expecting I missed somethings here and will need to update