You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell the internal test runner to use expected_results.txt instead of skipped_tests.txt as its control file. (The internal runner has learned to translate the expected_results.txt format to what it needs.)
Move skips for the two XFAIL: msvc tests from skipped_tests into expected_results. (LIT ignores these, but the internal runner needs them.)
Remove main from compile-only tests in std; the internal test runner understands compile-only tests now.
* Tell the internal test runner to use `expected_results.txt` instead of `skipped_tests.txt` as its control file. (The internal runner has learned to translate the `expected_results.txt` format to what it needs.)
* Move skips for the two `XFAIL: msvc` tests from `skipped_tests` into `expected_results`. (LIT ignores these, but the internal runner needs them.)
* Remove `main` from compile-only tests in `std`; the internal test runner understands compile-only tests now.
This is a dual of MSVC-PR-453118.
StephanTLavavejon Mar 23, 2020
I am concerned that we now have two lists of skipped tests for libcxx; this seems like it will get desynced easily. Is there some way to rely on a single list, or possibly a main list with a small secondary list of Python-runner-specific skips? Ideally, someone with a libcxx update that passes checks on GitHub should automatically pass on MSVC-internal and vice versa.
Is there some way to rely on a single list, or possibly a main list with a small secondary list of Python-runner-specific skips?
I had always thought this needed to look like "teach the internal test runner to run LIT", until roughly the 10,000th time I did the "copy from expected_results.txt to skipped_tests.txt, strip std/ prefix, strip any :0 MEOW suffix, and replace / with \" dance and it occurred to me that we could simply have the internal test runner do that. It seems so obvious in hindsight.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expected_results.txtinstead ofskipped_tests.txtas its control file. (The internal runner has learned to translate theexpected_results.txtformat to what it needs.)XFAIL: msvctests fromskipped_testsintoexpected_results. (LIT ignores these, but the internal runner needs them.)mainfrom compile-only tests instd; the internal test runner understands compile-only tests now.This is a dual of MSVC-PR-453118.