Implement LWG-3821 uses_allocator_construction_args should have overload for pair-like
#3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Feb 27, 2023
tests/std/tests/P0475R1_P0591R4_uses_allocator_construction/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Feb 28, 2023
strega-nil-ms
approved these changes
Feb 28, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
Apart from nit, looks good.
StephanTLavavej
approved these changes
Feb 28, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this purr-like overload! 🐈 😻 🐈⬛ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3415.
LWG-3821 patches P2165R4, so it should only be applied to C++23 mode. I think the overload added by LWG-3821 can be merged with the one added by LWG-3525.