Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement P2652R2 Disallowing User Specialization Of allocator_traits #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 6 commits into from
Mar 7, 2023
Merged

Implement P2652R2 Disallowing User Specialization Of allocator_traits #3542

StephanTLavavej merged 6 commits into from
Mar 7, 2023

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Mar 6, 2023 •
edited by StephanTLavavej
Loading

Fixes #3443. Also enables support and test coverage for EDG.

Upgrades allocator_traits::allocate_at_least to _NODISCARD_RAW_PTR_ALLOC.

I've filed DevCom-10301073 to request compiler support for this. Given compilers are already required to reject initializer_list specialization declarations, I think it's reasonable to do the same thing for allocator_traits.

@frederick-vs-ja
Implement P2652R2
4dfad15 
Also enable EDG support and test coverage
@frederick-vs-ja
Mention P2652R2 in yvals_core.h
4ca9c31
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 6, 2023 16:40
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Mar 6, 2023
StephanTLavavej
StephanTLavavej reviewed Mar 6, 2023
View reviewed changes
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Mar 6, 2023

Thanks! 😻 I've pushed very minor changes, including a tiny throughput improvement. FYI @strega-nil-ms as you already approved.

@StephanTLavavej StephanTLavavej self-assigned this Mar 7, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Mar 7, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit daa994b into microsoft:main Mar 7, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Mar 7, 2023

Thanks again for updating allocate_at_least()'s machinery, improving its nodiscard diagnostic, and requesting compiler support to keep bad kitties from jumping up on the table where they're not allowed! ⚙️ 🐈 😻

@StephanTLavavej StephanTLavavej mentioned this pull request Mar 7, 2023
Merged
@frederick-vs-ja frederick-vs-ja deleted the p2652r2 branch March 7, 2023 23:12
@frederick-vs-ja frederick-vs-ja mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx23 C++23 feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P2652R2 Disallowing User Specialization Of allocator_traits

3 participants

@frederick-vs-ja @StephanTLavavej @strega-nil-ms