Improve _(Add|Multiply)_with_overflow_check
#3678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
May 1, 2023
barcharcraz
approved these changes
May 4, 2023
strega-nil-ms
approved these changes
May 16, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
This looks reasonable to me. Thanks for fixing the unsigned short UB!
Contributor
|
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Contributor
|
Thanks for fixing bugs in these functions that are supposed to defend against bugs. |
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_(Add|Multiply)_with_overflow_checkto_Add_overflowand_Mul_overflowfor simplicity,__builtin_add_overflowand__builtin_mul_overflow),<xutility>,<mdspan>implementation,_Mul_overfloware equal tonumeric_limits<uint16_t>::max(), then signed integer overflow occurs,static_casts in_Mul_overflow's LLVM-based branch,