Move some components from upstream headers to downstream #3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that they can be `#undef`'d in the same header. Also demacroize `_MAX_INT_DIG` and rename it to `_Max_int_dig`, because it is used in multiple headers.
where the standard provides it, together with its friends.
from `<utility>` to `<__msvc_iter_core.hpp>` where suitable. Although they are unrelated to iterators.
to tests/tr1/tests/utility
CaseyCarter
approved these changes
May 19, 2023
Just a couple of pre-existing comment nits.
StephanTLavavej
approved these changes
May 25, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving our header structure and very slightly increasing throughput for rare TUs! 🎉 ✨ 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_MAX_*macros from<yvals.h>to<xlocnum>so that they can be#undef'd in the same header. Also demacroize_MAX_INT_DIGand rename it to_Max_int_dig, because it is used in multiple headers.integer_sequenceand its friends from<type_traits>to<utility>where the standard provides them.allocator_arg,uses_allocatorand their friends from<utility>to<__msvc_iter_core.hpp>where suitable. Although they are unrelated to iterators.