Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add static for some _Xxxx() member functions #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 5 commits into from
Jun 15, 2023
Merged

Add static for some _Xxxx() member functions #3755

StephanTLavavej merged 5 commits into from
Jun 15, 2023

Conversation

@achabense
Copy link
Contributor

@achabense achabense commented Jun 8, 2023

For example, void _Xran() const ~> static void _Xran().

@achabense achabense requested a review from a team as a code owner June 8, 2023 03:47
@achabense achabense closed this Jun 8, 2023
@achabense achabense reopened this Jun 8, 2023
@fsb4000
Copy link
Contributor

fsb4000 commented Jun 8, 2023

Remove some spaces at line below _Ty _Elems[_Size];

diff --git a/stl/inc/array b/stl/inc/array
index 1955ab12..53de2fd7 100644
--- a/stl/inc/array
+++ b/stl/inc/array
@@ -571,7 +571,7 @@ public:
     }
 
     _Ty _Elems[_Size];
-    
+
 private:
     [[noreturn]] static void _Xran() {
         _Xout_of_range("invalid array<T, N> subscript");

@CaseyCarter CaseyCarter added the performance Must go faster label Jun 8, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 14, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jun 14, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 444ea04 into microsoft:main Jun 15, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jun 15, 2023

Thanks for this small cleanup to improve codegen, and congratulations on the first of several microsoft/STL commits! 🎉 😻 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

performance Must go faster

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@achabense @fsb4000 @StephanTLavavej @CaseyCarter @strega-nil-ms