Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement LWG-3893 LWG-3661 broke atomic<shared_ptr<T>> a; a = nullptr; #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 1 commit into from
Jun 22, 2023
Merged

Implement LWG-3893 LWG-3661 broke atomic<shared_ptr<T>> a; a = nullptr; #3782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stl/inc/memory
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4003,6 +4003,10 @@ public:
store(_STD move(_Value));
}

void operator=(nullptr_t) noexcept {
store(nullptr);
}

~atomic() {
const auto _Rep = this->_Repptr._Unsafe_load_relaxed();
if (_Rep) {
Expand Down
9 changes: 9 additions & 0 deletions tests/std/tests/P0718R2_atomic_smart_ptrs/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

#include <cassert>
#include <cstddef>
#include <cstdint>
#include <memory>
#include <thread>
#include <type_traits>
#ifdef _DEBUG
#include <crtdbg.h>
#endif // _DEBUG
Expand Down Expand Up @@ -632,6 +634,13 @@ int main() {
ensure_member_calls_compile<atomic<shared_ptr<int[2][2]>>>();
ensure_member_calls_compile<atomic<weak_ptr<int[2][2]>>>();

// LWG-3893: LWG 3661 broke atomic<shared_ptr<T>> a; a = nullptr;
static_assert(is_nothrow_assignable_v<atomic<shared_ptr<bool>>, nullptr_t>);
static_assert(is_nothrow_assignable_v<atomic<shared_ptr<int>>, nullptr_t>);
static_assert(is_nothrow_assignable_v<atomic<shared_ptr<int[]>>, nullptr_t>);
static_assert(is_nothrow_assignable_v<atomic<shared_ptr<int[][2]>>, nullptr_t>);
static_assert(is_nothrow_assignable_v<atomic<shared_ptr<int[2][2]>>, nullptr_t>);

#ifdef _DEBUG
sptr0 = {};
sptr1 = {};
Expand Down