<iterator>: Modernize and deprecate (un)checked_array_iterator
#3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Jun 21, 2023
tests/std/tests/Dev10_709166_checked_and_unchecked_array_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_709166_checked_and_unchecked_array_iterator/test.cpp
Outdated
Show resolved
Hide resolved
Completing the story of contiguous iterators.
CaseyCarter
approved these changes
Jun 22, 2023
strega-nil-ms
approved these changes
Jun 30, 2023
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! I'll validate and push changes.
| "warning STL4043: stdext::checked_array_iterator, stdext::unchecked_array_iterator, and related factory " \ | ||
| "functions are non-Standard extensions and will be removed in future. std::span (since C++20) and gsl::span " \ | ||
| "can be used instead. You can define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING or " \ | ||
| "_SILENCE_ALL_CXX17_DEPRECATION_WARNINGS to suppress this warning.")]] |
Member
There was a problem hiding this comment.
It is debatable whether this should be controlled by the coarse-grained _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS as this is a Microsoft deprecation, not an ISO deprecation. On the other hand, guarding this with _HAS_CXX17 will significantly limit the impact on legacy code (which is good). I suppose I am fine with this; the precedent doesn't even really matter since we are running out of unwise Microsoft extensions to deprecate.
tests/std/tests/Dev10_709166_checked_and_unchecked_array_iterator/test.cpp
Show resolved
Hide resolved
tests/std/tests/Dev10_709166_checked_and_unchecked_array_iterator/test.cpp
Show resolved
Hide resolved
tests/std/tests/Dev10_709166_checked_and_unchecked_array_iterator/test.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jul 1, 2023
Member
|
FYI @strega-nil-ms I pushed changes after you approved; probably the most significant being the removal of deprecation on the |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for enhancing and then discouraging use of this old machinery! 🏚️ 🏡 ✨ |
|
This deprecation triggered build errors in cpprestsdk: microsoft/cpprestsdk#1768. |
11 tasks
11 tasks
7 tasks
briv
added a commit
to trice-imaging/vcpkg
that referenced
this pull request
Nov 21, 2023
Due to the msvc compiler change in microsoft/STL#3818, the aws-sdk-cpp CI build breaks (warnings are treated as errors). A fix is available upstream when we upgrade our vcpkg ports but to avoid an immediate upgrade, we'll define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING for now.
briv
added a commit
to trice-imaging/vcpkg
that referenced
this pull request
Nov 21, 2023
Due to the msvc compiler change in microsoft/STL#3818, the aws-sdk-cpp CI build breaks (warnings are treated as errors). A fix is available upstream when we upgrade our vcpkg ports but to avoid an immediate upgrade, we'll define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING for now.
briv
added a commit
to trice-imaging/vcpkg
that referenced
this pull request
Nov 21, 2023
Due to the msvc compiler change in microsoft/STL#3818, the aws-sdk-cpp CI build breaks (warnings are treated as errors). A fix is available upstream when we upgrade our vcpkg ports but to avoid an immediate upgrade, we'll define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING for now.
briv
added a commit
to trice-imaging/vcpkg
that referenced
this pull request
Nov 21, 2023
Due to the msvc compiler change in microsoft/STL#3818, the aws-sdk-cpp CI build breaks (warnings are treated as errors). A fix is available upstream when we upgrade our vcpkg ports but to avoid an immediate upgrade, we'll define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING for now.
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #943. Fixes #951.
This PR
(un)checked_array_iterator<T*>to(un)checked_array_iterator<const T*>,(un)checked_array_iteratorandmake_(un)checked_array_iteratorin C++17 and later modes, while allowing users to define_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNINGto suppress the deprecation,(un)checked_array_iterator<void*>and(un)checked_array_iterator<Ret(*)(Args...)>instatic_assert,iterator_traits<Ptr>::meowtypedefs,make_checked_array_iterator, and(un)checked_array_iteratorare contiguous iterators in C++20.