<filesystem>: fix dangerous noexcept specification of _Current_path
#3869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Jul 13, 2023
Member
|
Great catch, thanks! 😻 I couldn't resist pushing a stylistic nitpick even though this resets testing. |
Member
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
strega-nil-ms
approved these changes
Jul 13, 2023
Member
|
Thanks for noticing and fixing this silent bad codegen! 🦅 👁️ ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Current_pathis wrongly marked asnoexcept, which will cause the program to terminate ifresizethrows.STL/stl/inc/filesystem
Lines 4045 to 4046 in 2261f7e
This pr fixes it by merging the function into throwable
path current_path(error_code&).