Avoid unnecessary handling in _ReportUnobservedException
#3909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celonymire
suggested changes
Jul 28, 2023
CaseyCarter
approved these changes
Jul 28, 2023
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Just some non-functional changes that I'll go ahead and push.
CaseyCarter
approved these changes
Jul 28, 2023
StephanTLavavej
approved these changes
Jul 28, 2023
celonymire
approved these changes
Jul 31, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
😵 💥
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3888
Changes:
__fastfailis always available. Mostly added as a reminder that this should be cleaned up further when dropping pre-Win8.terminatetoabortas discussed in Consider unifying existing practices ofdon't-callfunctions #3888 (comment)abort()if always calling__fastfail. IMO, the compiler should make the assumption that__fastfaildoes not return by itself, added DevCom-10425806.