-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Vectorize ranges::find_last
#3925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Oct 7, 2023
Contributor
Author
|
I observe that #4004 does a bulk change, which applies here too, will do when that PR lands |
StephanTLavavej
requested changes
Oct 9, 2023
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Oct 11, 2023
CaseyCarter
approved these changes
Oct 18, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for optimizing this new algorithm! 🚀 🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3274
The implementation in
vector_algorithm.cppis similar to the forward find, except:_Lastto negative direction_Rewind_byteswas introduced. This helps avoiding castingsize_ttoptrdiff_tand running into potential UB due to overflow when the range is more than half addressable space_Advance_byteswas made template to fix pre-existing potentially largesize_ttoptrdiff_tconversion_BitScanForward-> _BitScanReverse._lzcnt_u32->_tzcnt_u32_BitScanForwardand_BitScanReverseindex from the least significant bit, so no changes here_tzcnt_u32index from most significant bit, so reverse using31 - x_tzcnt_u32is present, same as_lzcnt_u32. We have precedent in<__msvc_bit_utils.hpp>The integration in
<algorithm>is similar toranges::find, except that we don't support unsized ranges (in this regard, similar toranges::count).The test uses the same random data as for forward find. I made sure it covers all branches of the algorithm.