Remove some functions defined in _CRTBLD blocks
#4005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
StephanTLavavej
approved these changes
Sep 7, 2023
Member
|
Looks good, thanks for noticing that this was possible! I verified that this doesn't affect the export surface so it should be completely safe to make this change. |
CaseyCarter
approved these changes
Sep 8, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for noticing and performing this cleanup! 🧹 🧹 🪄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
open(const unsigned short*,...)functions from the library.These functions are defined in
_CRTBLDblocks, and are not used elsewhere in the library.The project can build successfully after their removal (or
=deletethem). Thexxx.dllandmsvcprt(d).libfiles are unchanged.Works towards #3941.