Prepare for impending LLVM 17 release #4014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.... which seems to confuse Clang 17.
StephanTLavavej
requested changes
Sep 7, 2023
CaseyCarter
commented
Sep 7, 2023
StephanTLavavej
approved these changes
Sep 7, 2023
* Move `_Maybe_const` up from `<ranges>` into `<type_traits>` * Use `is_rvalue_reference_v<T&&>` instead of `is_lvalue_reference_v<T>`. I'm certain they are complements - so it doesn't matter for correctness - but the former more closely matches the Standard wording which makes things easier for code readers.
StephanTLavavej
requested changes
Sep 8, 2023
Push it down from `<utility>` into `<__msvc_iter_core.hpp>`
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
strega-nil-ms
approved these changes
Sep 8, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
I prefer the updated forward_like anyways.
StephanTLavavej
approved these changes
Sep 8, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for scouting out LLVM 17! 🏞️ 🥾 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested with LLVM 17.0.0-rc4 and found a couple of issues / regressions:
<ranges>with LLVM-61763 and added another similar workaround forzip_transform_view.forward_like(LLVM-64029)