-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add * tags to all non-tagged configs
#4068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... in our test matrices. `RUNALL_CROSSLIST` forms the cross product of all lines from above with all lines from below, and from each pairing whose tag sets intersect produces a new line tagged with the intersection that defines all variables defined on either line, with values that are the concatenation of the values from `x` and `y`. Non-tagged lines are treated as if they are all tagged with the same value, and `*` is the identity element for tag set intersection. For example: ``` MEOW=A X MEOW=B Y MEOW=C * MEOW=D RUNALL_CROSSLIST WOOF=1 X,Y WOOF=2 X WOOF=3 Y MEOW=E WOOF=4 ``` is equivalent to: ``` MEOW=A WOOF=1 X MEOW=B WOOF=2 X MEOW=B WOOF=3 Y MEOW=C WOOF=2 Y MEOW="C E" WOOF=4 MEOW=D WOOF=1 X,Y MEOW=D WOOF=2 X MEOW=D WOOF=3 Y MEOW="D E" WOOF=4 ``` [microsoftGH-4052](microsoft#4052) added `*` tags to all non-leaf lines so they would properly combine with leaf configurations that have either an `ASAN` or empty tag. There's a danger of "losing" `ASAN` configurations if we add a crosslist that inadvertently matches untagged lines with `ASAN` lines. We decided that all lines should be tagged with either `ASAN` or `*` to lessen the likelihood of such a mistake.
* tags to all non-tagged configs
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I searched carefully for any missed lines and didn't find them. |
|
There are no stealth conflicts with the Ready To Merge PRs (a few are adding |
|
I agree, this should not be problematic. I manually queued an ASAN run for good measure (https://dev.azure.com/vclibs/STL/_build/results?buildId=15321&view=results) and it is nicely green. |
⭐ 🌟 🤩 |
This reverts commit 283cf32.
This reverts commit 283cf32.
... in our test matrices.
RUNALL_CROSSLISTforms the cross product of all lines from above with all lines from below, and from each pairing whose tag sets intersect produces a new line tagged with the intersection that defines all variables defined on either line, with values that are the concatenation of the values fromxandy. Non-tagged lines are treated as if they are all tagged with the same value, and*is the identity element for tag set intersection. For example:is equivalent to:
GH-4052 added
*tags to all non-leaf lines so they would properly combine with leaf configurations that have either anASANor empty tag. There's a danger of "losing"ASANconfigurations if we add a crosslist that inadvertently matches untagged lines withASANlines. We decided that all lines should be tagged with eitherASANor*to lessen the likelihood of such a mistake.