Thanks to visit codestin.com
Credit goes to github.com

Skip to content

<format>: Guard one use of _MSVC_EXECUTION_CHARACTER_SET #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 1 commit into from
Oct 14, 2023
Merged

<format>: Guard one use of _MSVC_EXECUTION_CHARACTER_SET #4076

StephanTLavavej merged 1 commit into from
Oct 14, 2023

Conversation

@cpplearner
Copy link
Contributor

@cpplearner cpplearner commented Oct 7, 2023

This allows EDG to parse <format> when __cpp_lib_concepts is defined. (__cpp_lib_concepts must be defined in order for <format> to work.)

Currently, __cpp_lib_concepts is not defined when the compiler is EDG, but I expect this to change soon.

STL/stl/inc/yvals_core.h

Lines 1704 to 1710 in f362f7d

#if !defined(__EDG__) || defined(__INTELLISENSE__) // TRANSITION, GH-395
#if _HAS_CXX23 // TRANSITION, GH-395 - move down to "macros with language mode sensitivity" section
#define __cpp_lib_concepts 202207L // P2404R3 Move-Only Types For Comparison Concepts
#else // ^^^ C++23 / C++20 vvv
#define __cpp_lib_concepts 202002L // P1964R2 Replacing boolean With boolean-testable
#endif // C++20
#endif // !defined(__EDG__) || defined(__INTELLISENSE__)

@cpplearner cpplearner requested a review from a team as a code owner October 7, 2023 11:05
@StephanTLavavej StephanTLavavej added enhancement Something can be improved format C++20/23 format labels Oct 8, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 8, 2023

Thanks, I think we only need one maintainer approval here.

@StephanTLavavej StephanTLavavej self-assigned this Oct 13, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 13, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 33ae7d2 into microsoft:main Oct 14, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 14, 2023

Thanks for scouting ahead and improving how EDG handles the STL's concepts-enabled code! 🥾 🏞️ 🎉

@cpplearner cpplearner deleted the patch-1 branch October 14, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved format C++20/23 format

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpplearner @StephanTLavavej