Implement formattable, range_format, and format_kind
#4116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement the part for `formattable` in LWG-3631 and LWG-3925 - Speculatively implement LWG-3997 (as done in libc++)
Unblocking libcxx tests.
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Oct 23, 2023
Member
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Oct 25, 2023
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
None of these comments is a serious defect, and I don't want to reset testing, so I'm going to approve. I'll pepare changes for these comments in a followup PR.
Member
|
Thanks for implementing more of this C++23 feature! 📈 🎉 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also speculatively implement LWG-3997 since libc++ is already doing this. Towards #2919.