<random>: Fix minor conformance issues
#4120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove it outright for Standard `discard_block_engine` (via the new base class `_Discard_block_base`), `independent_bits_engine`, and `shuffle_order_engine`. For `discard_block`, which is usually the base class for Standard `discard_block_engine`, we can guard the typedef with TR1's availability, and deprecate it. We should then avoid using it ourselves.
…scard_block_base`. `discard_block_engine` had an `_Engine&&` constructor but its base classes didn't, so it was always copying.
CaseyCarter
approved these changes
Oct 24, 2023
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_typein<random>is a non-Standard typedef.discard_block_engine(via the new base class_Discard_block_baseintroduced by Implement LWG-3561 Issue with internal counter indiscard_block_engine#4066),independent_bits_engine, andshuffle_order_engine.discard_block, which is usually the base class for Standarddiscard_block_engine, we can guard the typedef with TR1's availability, and deprecate it. We should then avoid using it ourselves._Engine&&constructors todiscard_blockand_Discard_block_base.discard_block_enginehad an_Engine&&constructor but its base classes didn't, so it was always copying.