Various cleanups: Simplify product code #4121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd against the preprocessor. After GH 3973, `_With_nested_v2<_Uty>` doesn't contain commas.
It's just zero.
Here's a case where a negative test allows us to considerably simplify the code by avoiding the need for two `#ifdef __cpp_lib_concepts` regions (which was hard to follow). Now the code reads much more naturally - in concepts mode, we need to handle different iterator/sentinel types.
…for `min` and `max`. A constructor above is already using this typedef.
…ing::_Eos()`. We prefer to avoid expressions with lots of side effects, so we should update `_Mysize` before indexing. I'm using `_New_size` for the index since it's shorter.
CaseyCarter
approved these changes
Oct 24, 2023
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<exception>:throw_with_nested()no longer needs_Gluedto defend against the preprocessor.<exception>#3973,_With_nested_v2<_Uty>doesn't contain commas.ios_base::_Iostate{}=>ios_base::goodbit_Copy_unchecked()'s#ifdef __cpp_lib_conceptslogic.#ifdef __cpp_lib_conceptsregions (which was hard to follow). Now the code reads much more naturally - in concepts mode, we need to handle different iterator/sentinel types.<random>:discard_block_enginecan use itsresult_typetypedef forminandmax.basic_string::_Eos()._Mysizebefore indexing. I'm using_New_sizefor the index since it's shorter.