Thanks to visit codestin.com
Credit goes to github.com

Skip to content

P2836R1: basic_const_iterator Should Follow Its Underlying Type's Convertibility #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 2 commits into from
Nov 17, 2023
Merged

P2836R1: basic_const_iterator Should Follow Its Underlying Type's Convertibility #4188

StephanTLavavej merged 2 commits into from
Nov 17, 2023

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Nov 13, 2023

Closes #4183.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner November 13, 2023 16:23
@StephanTLavavej StephanTLavavej added ranges C++20/23 ranges cxx23 C++23 feature defect report Applied retroactively labels Nov 13, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 13, 2023
StephanTLavavej
StephanTLavavej reviewed Nov 13, 2023
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Nov 13, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 13, 2023

Thanks, this looks great! I pushed some tiny style nitpicks for the test. I think this needs only one maintainer approval.

@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 16, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c343c8c into microsoft:main Nov 17, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 17, 2023

Thanks for implementing this C++23 DR! 🎉 🐈 🚀

@JMazurkiewicz JMazurkiewicz deleted the P2836R1 branch November 17, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx23 C++23 feature defect report Applied retroactively ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P2836R1 basic_const_iterator Should Follow Its Underlying Type's Convertibility

2 participants

@JMazurkiewicz @StephanTLavavej