Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JMazurkiewicz
Copy link
Contributor

Closes #3799.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner November 15, 2023 17:13
@StephanTLavavej StephanTLavavej added format C++20/23 format cxx26 C++26 feature labels Nov 15, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 15, 2023
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej removed their assignment Jan 11, 2024
@StephanTLavavej
Copy link
Member

Thanks!! 😻 I pushed a merge with main, resolving the conflict in tests/libcxx/expected_results.txt by enabling the tests for this feature, then I updated comments/messages to address @barcharcraz's feedback, and finally nitpicky feedback of my own.

@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej dismissed barcharcraz’s stale review January 11, 2024 21:49

Feedback has been addressed

@StephanTLavavej StephanTLavavej merged commit c5afe05 into microsoft:main Jan 11, 2024
@StephanTLavavej
Copy link
Member

Thanks for implementing this "I can't believe it's not a DR" feature! 😹 😻 😸

@JMazurkiewicz JMazurkiewicz deleted the format/🅱️ointers branch January 13, 2024 13:46
@frederick-vs-ja
Copy link
Contributor

Thanks for bumping __cpp_lib_format to its final value in C++20 mode, which indicates a date later than the "finalization of C++20“ by 38 months!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx26 C++26 feature format C++20/23 format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P2510R3 Formatting Pointers

4 participants