Allow locale{nullptr} to compile
#4245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by
std/localization/locales/locale/locale.cons/char_pointer.pass.cppin the upcoming libcxx update:WG21-N4964 [member.functions]/2:
The set of constructors depicted in [locale.general] means that
locale{nullptr}should compile, even though [locale.cons]/3 says that when it selectsexplicit locale(const char* std_name);:libc++'s test suite expects exactly this.
C++ is intentionally designed to perform access control after overload resolution (citation left as an exercise to the reader), so the
privateconstructorlocale(_Locimp*)disrupts this. We can add an internal tag to restore conformance. Because this isprivate, the tag can also beprivate.Verified that there are no differences in release or debug exports (perhaps surprisingly,
localeisn't separately compiled, although its unindicted co-conspirators are).