Thanks to visit codestin.com
Credit goes to github.com

Skip to content

<ranges>: Fix truncation warnings and improve overflow check for repeat_view #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 6 commits into from
Jan 17, 2024
Merged

<ranges>: Fix truncation warnings and improve overflow check for repeat_view #4255

StephanTLavavej merged 6 commits into from
Jan 17, 2024

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Dec 10, 2023

Fixes #4251.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner December 10, 2023 12:00
@StephanTLavavej StephanTLavavej added bug Something isn't working ranges C++20/23 ranges labels Dec 11, 2023
@StephanTLavavej StephanTLavavej self-assigned this Dec 11, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Dec 15, 2023
Merged
StephanTLavavej
StephanTLavavej reviewed Jan 13, 2024
View reviewed changes
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 13, 2024

Thanks for fixing this libcxx failure! I pushed a conflict-free merge with main followed by a couple of style nitpicks and correcting a duplicated test line.

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 17, 2024

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 17, 2024

I've pushed a merge with main to resolve a trivial adjacent-edit conflict in tests/libcxx/expected_results.txt.

@StephanTLavavej StephanTLavavej merged commit c902810 into microsoft:main Jan 17, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 17, 2024

Thanks for repeatedly fixing these libcxx failures! 🔁 😹 🎉

@frederick-vs-ja frederick-vs-ja deleted the repeat_view-off-check branch January 17, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<ranges>: repeat_view<T, unsigned int> emits truncation warnings

2 participants

@frederick-vs-ja @StephanTLavavej