Thanks to visit codestin.com
Credit goes to github.com

Skip to content

<vector>: Cast to the correct base type in vector<bool, Alloc>::_Orphan_range_unlocked #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 1 commit into from
Jan 11, 2024
Merged

<vector>: Cast to the correct base type in vector<bool, Alloc>::_Orphan_range_unlocked #4276

StephanTLavavej merged 1 commit into from
Jan 11, 2024

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Dec 17, 2023

I've confirmed that @StephanTLavavej's analysis for the related test failure was correct.

Possible STL bug, _Vb_reference derives from _Vb_iter_base and is adopted by the container, but _Orphan_range_unlocked assumes every child is a const_iterator.

This PR exposes _Mybase for the convenience of casting, and removes some unnecessary _Difference_type member type alias as driven-by changes. (It seems better to me to use difference_type whenever it's available.)

Unblocks one libcxx test:

  • std/containers/sequences/vector.bool/emplace_back.pass.cpp

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner December 17, 2023 17:39
@StephanTLavavej StephanTLavavej self-assigned this Dec 18, 2023
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Dec 18, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 11, 2024

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1444b44 into microsoft:main Jan 11, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 11, 2024

Thanks for confirming my initial investigation and figuring out how to fix this libcxx failure! 📉 😻 🛠️

@frederick-vs-ja frederick-vs-ja deleted the cast-to-vb-iter-base branch January 11, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frederick-vs-ja @StephanTLavavej @CaseyCarter