Make implicit conversion to bool ADL-proof (except for views)
#4334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by `_STD`-qualifying `_Fake_copy_init`.
tests/std/tests/GH_000140_adl_proof_comparison/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_000140_adl_proof_comparison/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_000140_adl_proof_comparison/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_000140_adl_proof_comparison/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jan 22, 2024
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Jan 23, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Qualify qualify qualify! 🛡️ 🛡️ 🛡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by
_STD-qualifying_Fake_copy_init. Towards #140.While dealing with #4318, I found that most, if not all, occurrences of
_Fake_copy_initin MSVC STL needed to be qualified.Fixed components:
equal_to,not_equal_to,less,greater,less_equal, andgreater_equalreverse_iterator,move_iterator(together withmove_sentinel), andbasic_const_iteratoroptionalexpected(together withunexpected)Views (in
<ranges>) are not yet touched since I haven't come up with testing examples, but I think occurrences of_Fake_copy_initin views also need to be qualified.