Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Run CTest tests serially to avoid oversubscribing cores #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 1 commit into from
Jan 25, 2024
Merged

Run CTest tests serially to avoid oversubscribing cores #4335

StephanTLavavej merged 1 commit into from
Jan 25, 2024

Conversation

@horenmar
Copy link
Contributor

@horenmar horenmar commented Jan 21, 2024

The lit tests are already internally parallelized, so using CTest to run them in parallel ends up with the CPU cores hopelessly oversubscribed.

@horenmar
Run CTest tests serially to avoid oversubscribing cores
3314a96 
The lit tests are already internally parallelized, so using CTest
to run them in parallel ends up with the CPU cores hopelessly
oversubscribed.
@horenmar horenmar requested a review from a team as a code owner January 21, 2024 13:05
fsb4000
fsb4000 approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@fsb4000 fsb4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that the CI time doesn't change after the update, and I also consulted the CMake documentation to ensure there were no misspellings:
https://cmake.org/cmake/help/latest/command/set_tests_properties.html
https://cmake.org/cmake/help/latest/prop_test/RUN_SERIAL.html

@StephanTLavavej StephanTLavavej added the test Related to test code label Jan 21, 2024
@StephanTLavavej StephanTLavavej self-assigned this Jan 21, 2024
@StephanTLavavej StephanTLavavej removed their assignment Jan 21, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 21, 2024

Thanks! I never run ctest (instead I always invoke stl-lit.py directly), so I didn't realize it was trying to run stl and stlasan simultaneously with separate Python invocations. Great catch 😻

@StephanTLavavej StephanTLavavej self-assigned this Jan 24, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 24, 2024

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d2d7fcc into microsoft:main Jan 25, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 25, 2024

Thanks again! 🎉 😸 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@horenmar @StephanTLavavej @CaseyCarter @fsb4000