Merge main to feature/generator
#4370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
…rosoft#4367) Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Resolved conflict in yvals_core.h, removing all guards around `__cpp_lib_generator` except `_HAS_CXX23`. * `__cpp_lib_concepts` is now always available in C++20 and later. * `<generator>` doesn't care about `std::byte` now. * C1XX, Clang, and EDG all define `__cpp_impl_coroutine` in C++20 and later, which wasn't the case earlier.
Also add a missing semicolon - this emits a `_Pragma`.
VSO-1951821 "EDG instantiates the wrong overload of `promise_type::operator new` for `generator` machinery"
CaseyCarter
suggested changes
Feb 7, 2024
CaseyCarter
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maintofeature/generatoryvals_core.h, removing all guards around__cpp_lib_generatorexcept_HAS_CXX23.__cpp_lib_conceptsis now always available in C++20 and later.<generator>doesn't care aboutstd::bytenow.__cpp_impl_coroutinein C++20 and later, which wasn't the case earlier.concepts_latest_matrix.lst=>usual_latest_matrix.lstVSO_0157762_feature_test_macrosto matchyvals_core.h.<generator>'s_HAS_CXX23guard and message._Pragma.promise_type::operator newforgeneratormachinery" by skippingstateful_alloccoverage for EDG.std.ixx: Guard<generator>with_HAS_CXX23.import <generator>;with#if TEST_STANDARD >= 23.^^^ no workaround ^^^comments around good code.