Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Feb 10, 2024

Fixes #4381

It seems htmlLabels are disabled by default now for some reason. But we can enable them.

It seems it works:
https://github.com/fsb4000/STL/tree/patch-1
изображение

@fsb4000 fsb4000 requested a review from a team as a code owner February 10, 2024 08:01
@fsb4000 fsb4000 changed the title README.md: allow htmltags inside flowchart README.md: allow htmlLabels inside flowchart Feb 10, 2024
@AlexGuteniev
Copy link
Contributor

This is not a flowchart, flowchart is a diagram that specifically shows control flow.

(Also from your screenshot it looks like that you're not using an up to date browser)

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Feb 10, 2024
@StephanTLavavej
Copy link
Member

From https://github.com/orgs/community/discussions/61266, I learned that you can query the version of Mermaid that GitHub is using with (replace single quotes with backticks):

'''mermaid
info
'''

Currently this is 10.0.2:

info
Loading

In Mermaid 10.1.0 we should be able to use Markdown-style **bold**.

Actual block diagrams were added in Mermaid 10.8.0 (apparently in beta form?), so it'll be a while before we can attempt to use them.

@fsb4000
Copy link
Contributor Author

fsb4000 commented Feb 11, 2024

Currently this is 10.0.2:

Yeah, there is an issue about updating the version: https://github.com/orgs/community/discussions/70672

It seems Github devs don't update dependecies too often: 10.0.2 was released on March 2, 2023 and that issue was created on Oct 21, 2023 and it is still open.

@StephanTLavavej StephanTLavavej self-assigned this Feb 12, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit bd3d740 into microsoft:main Feb 13, 2024
@StephanTLavavej
Copy link
Member

Thanks for fixing this documentation regression - the bits literally rotted! 😹 🛠️ 🎉

@fsb4000 fsb4000 deleted the patch-1 branch February 13, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

readme.md: <b> / </b> in the block diagram do not work

3 participants