Thanks to visit codestin.com
Credit goes to github.com

Skip to content

<xutility>, <algorithm>: Add top level const on pointer parameters #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 3 commits into from
Feb 27, 2024
Merged

<xutility>, <algorithm>: Add top level const on pointer parameters #4410

StephanTLavavej merged 3 commits into from
Feb 27, 2024

Conversation

@d-kamath
Copy link
Contributor

@d-kamath d-kamath commented Feb 19, 2024

Closes #4385

This PR adds the top-level const to the _Ty* _First, _Ty* _Last parameters for the following functions
<algorithm> : __std_minmax_element, __std_minmax
<xutility>: __std_find_trivial_unsized, __std_min, __std_max

@d-kamath d-kamath requested a review from a team as a code owner February 19, 2024 01:02
@d-kamath
Copy link
Contributor Author

d-kamath commented Feb 19, 2024

@KamathScience please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree

Contributor License Agreement

@microsoft-github-policy-service agree

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Feb 19, 2024

Changes for following functions still seem missing:

In <xutility>:

  • __std_count_trivial
  • __std_find_trivial
  • __std_min_element
  • __std_max_element

In <algorithm>:

  • __std_find_last_trivial

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Feb 19, 2024
@StephanTLavavej StephanTLavavej self-assigned this Feb 19, 2024
@StephanTLavavej StephanTLavavej removed their assignment Feb 21, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 21, 2024

Looks great, thanks! We merge PRs simultaneously to the MSVC-internal and GitHub repos in a semi-manual process, batching up PRs to save time. Your PR will be part of the next batch, likely later this week - I'll post comments as I mirror the PRs and then finally merge 'em.

@d-kamath
Copy link
Contributor Author

d-kamath commented Feb 21, 2024

Thank you all, this process has been incredibly smooth for me!

@StephanTLavavej StephanTLavavej self-assigned this Feb 23, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 23, 2024

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 605c733 into microsoft:main Feb 27, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 27, 2024

Thanks again, and congratulations on your first microsoft/STL commit! 🎉 🥳 😸

This is expected to ship in VS 2022 17.10 Preview 3, and has been recorded in the STL Changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@AlexGuteniev AlexGuteniev AlexGuteniev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<xutility>, <algorithm>: vector algorithms dispatching functions miss top level const on pointer parameters

4 participants

@d-kamath @frederick-vs-ja @StephanTLavavej @AlexGuteniev