Comment cleanups #4439
Merged
Comment cleanups #4439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer necessary after microsoft/GSL 822.
…conventional ones.
…guage mode sensitivity". This eliminates one last occurrence of `^^^ C++23 / C++20 vvv`. We were pretty inconsistent about the patterns here, and these comments were distracting from the actually useful paper citations. The regions here are all single line, so it's okay to skip preprocessor comments. The only comment I retained was `#endif // language mode` because it's next to `#endif // !defined(_M_CEE_PURE)`.
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// inspected by GSL, do not remove.C++23 / C++20=>_HAS_CXX23 / !_HAS_CXX23_HAS_CXX23comments with conventional ones.^^ real test / vv workaroundcomments with conventional ones.yvals_core.h, drop most comments around "macros with language mode sensitivity".^^^ C++23 / C++20 vvv. We were pretty inconsistent about the patterns here, and these comments were distracting from the actually useful paper citations. The regions here are all single line, so it's okay to skip preprocessor comments. The only comment I retained was#endif // language modebecause it's next to#endif // !defined(_M_CEE_PURE).