Tests: Extract is_permissive.hpp
#4442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on test_mdspan_support.hpp, with `namespace details` renamed to `namespace detail` (see below). Its `PermissiveTestBase` and `PermissiveTest` were nicely named, and it was using `inline constexpr bool`. Also add `is_permissive_v<T>`, when we need it to be dependent on a template parameter. We need to include `<yvals_core.h>` for `_INLINE_VAR`, since there's some C++14 usage. test_mdspan_support.hpp: Drive-by change, this file had both `namespace details` and `namespace detail`. Standardize on the latter, as it's used everywhere else. P2136R3_invoke_r: `// TRANSITION, DevCom-1457457` is repeated where `is_permissive` is used, so we can drop the one next to the definition.
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've accumulated a bunch of test files copy-pasting the machinery used to detect
/permissivemode. Let's centralize it.This is based on
test_mdspan_support.hpp, withnamespace detailsrenamed tonamespace detail(see below). ItsPermissiveTestBaseandPermissiveTestwere nicely named, and it was usinginline constexpr bool. Also addis_permissive_v<T>, when we need it to be dependent on a template parameter. We need to include<yvals_core.h>for_INLINE_VAR, since there's some C++14 usage.test_mdspan_support.hpp: Drive-by change, this file had bothnamespace detailsandnamespace detail. Standardize on the latter, as it's used everywhere else.P2136R3_invoke_r:// TRANSITION, DevCom-1457457is repeated whereis_permissiveis used, so we can drop the one next to the definition.