Various cleanups: product code #4444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid dead code.
… and alias templates. This became possible after my GH 4146 moved these functions into `namespace std`.
…++ compiler." like GH 4020.
Then we can move `_STL_STRINGIZE` down to its point of use, near our other macros.
```
D:\GitHub\STL\out\x64>type woof.c
#include <vector>
D:\GitHub\STL\out\x64>cl /EHsc /nologo /W4 /c woof.c
woof.c
D:\GitHub\STL\out\x64\out\inc\yvals_core.h(23): fatal error C1189: #error: error STL1003: Unexpected compiler, expected C++ compiler.
```
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Popcount_fallback(), afterif constexpr ... returnaddelseto avoid dead code.if constexpr._STDqualification on types, variable templates, and alias templates.namespace std.yvals_core.h: Improve "error STL1003: Unexpected compiler, expected C++ compiler." like use onlystatic_assertfor_EMIT_STL_ERROR#4020._STL_STRINGIZEdown to its point of use, near our other macros.