Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@StephanTLavavej
Copy link
Member

I've validated this with an internal build and test run. I know there's not a lot of value in cleaning up old src files, but this eliminates some complexity and I believe it's safe.

  • RtlCaptureStackBackTrace is universally available.
    • It might not have been when this was originally implemented, but it's now documented as "Target Platform: Universal", and this aligns with its actual declaration.
  • Move GUID into Concurrency::details within #if defined(_CRT_APP) || defined(UNDOCKED_WINDOWS_UCRT).
    • It's static, so there's no ABI impact.
  • We don't need <mutex> - only <functional> for std::function and <stdexcept> for std::runtime_error.
  • Drop "ASYNC TODO" comment.
    • We're never going to change this legacy behavior.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 4, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 4, 2024 02:17
@StephanTLavavej StephanTLavavej self-assigned this Mar 6, 2024
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0407db6 into microsoft:main Mar 8, 2024
@StephanTLavavej StephanTLavavej deleted the cleanups-7-people-tasks branch March 8, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant