Implement LWG-3767 codecvt<charN_t, char8_t, mbstate_t> incorrectly added to locale
#4542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
215a4a1 to
05fc45f
Compare
Shrink the primary template's `_ENFORCE_FACET_SPECIALIZATIONS` list because `codecvt_byname<char16_t, char8_t, mbstate_t>` and `codecvt_byname<char32_t, char8_t, mbstate_t>` are becoming (deprecated) explicit specializations. Note that `codecvt_byname<char16_t, char, mbstate_t>` and `codecvt_byname<char32_t, char, mbstate_t>` were simply missing. Add the old and new deprecated explicit specializations, the latter being guarded by `#ifdef __cpp_char8_t`. Note that (unlike the primary template) they can use the injected-class-name `codecvt` in their delegating constructors because it isn't dependent anymore. There didn't seem to be a simple way to centralize this repetition without adding too much complexity, so I just spammed it out. We need to `_STL_DISABLE_DEPRECATED_WARNING`/`_STL_RESTORE_DEPRECATED_WARNING` because the base classes are deprecated.
StephanTLavavej
approved these changes
Apr 2, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4498. The message in warning STL4020 should also be changed.
I think
std::filesystem::pathis the only thing in the C++ standard library that can be used as a replacement.Currently this PR applies the deprecation to C++20 mode to be consistent with
_CXX20_DEPRECATE_CODECVT_FACETS, but I'm not sure whether this is appropriate.