Drop inline/_INLINE_VAR from templated constexpr variables in product and test codes
#4546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e18ee96 to
d7e4c4c
Compare
StephanTLavavej
approved these changes
Apr 2, 2024
Member
|
Thanks for the extremely careful work! I audited all changes for correctness (all were templated), found only one missed occurrence, and then audited all remaining cases of |
Merged
StephanTLavavej
approved these changes
Apr 8, 2024
Member
|
I've pushed a commit to pre-emptively avoid a merge conflict; #4554 will be removing |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for auditing all of these now-unnecessary keywords! 🪄 🔍 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4533.