Manually vectorize for at least SSE4.2 #4550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Apr 3, 2024
Member
|
Perfect! 😻 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for dramatically reducing our risk here, and slightly improving perf for modern processors! 😻 🎉 🚀 |
What risk does this reduce? |
Contributor
Author
See the description of the issue closed by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4536
Also checked and improved where can take advantage of new assumptions:
_mm_set1_epi8replaced with_mm_shuffle_epi8with zero input, slight improvement for 1-byte elementsfindandcount__std_bitset_to_string_*_mm_shuffle_epi8to populate a__m128ivariable instead of the sequence_mm_blendv_epi8to avoidxorDidn't measure the results. If measured on a modern machine, that would be artificial to alter
__isa_enabled, and still not relevant.Also removed SSE level of instructions from comments. Kept
__popcntcomment though.