Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JMazurkiewicz
Copy link
Contributor

  • Add tests for generator's iterator type in separate P2502R2_generator_iterator/test.cpp file
  • Add test_generator_support.hpp header
  • Move
    static_assert(sizeof(ranges::iterator_t<G>) == sizeof(void*));
    test from P2502R2_generator/test.cpp to the new file.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner April 10, 2024 19:47
@CaseyCarter CaseyCarter added cxx23 C++23 feature generator C++23 generator labels Apr 10, 2024
@StephanTLavavej StephanTLavavej added the test Related to test code label Apr 10, 2024
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej
Copy link
Member

Thanks! The checks are actually green but the status didn't update. I won't force a rerun since Casey might want to push changes.

Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push changes for these comments. Thanks for working on this!

@StephanTLavavej StephanTLavavej merged commit 7928387 into microsoft:feature/generator Apr 17, 2024
@StephanTLavavej
Copy link
Member

Thanks @JMazurkiewicz and @CaseyCarter! 😻 ✅ ⚡

@JMazurkiewicz JMazurkiewicz deleted the generator/test_iterator branch April 18, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx23 C++23 feature generator C++23 generator test Related to test code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants