Change _Always_false to false for functions
#4591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevCom-10554332 VSO-1936351 was fixed by MSVC-PR-520085 on 2024-01-09, shipping in VS 2022 17.10 Preview 1. Clang 17 started supporting this. EDG isn't completely happy yet, see VSO-2016422.
This was attempting to generate a dedicated diagnostic for CTAD, but it wasn't working. (It could be fixed for Clang, but it would look weird, and it still wouldn't work for MSVC.) Just mention both scenarios.
Member
Author
|
/azp run STL-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as resolved.
This comment was marked as resolved.
AlexGuteniev
approved these changes
Apr 15, 2024
…22 (EDG)` ... to ensure we don't miss them when removing workarounds.
CaseyCarter
approved these changes
Apr 18, 2024
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
Author
|
Azure Pipelines checks are green, but GitHub's UI isn't reflecting that. I'm going to need to resolve merge conflicts with #4588 so there's no point in forcing a rerun now. |
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Always_false._Always_falseusage in functions withfalse.always_falsetest helpers in functions.AlwaysFalseinVSO_0000000_more_pair_tuple_sfinae(thanks @frederick-vs-ja!).static_asserts in_Move_only_function_call.