<xstring>: Make char_traits::assign not start lifetime of elements
#4613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Apr 21, 2024
Member
|
Thanks - I agree that this change is correct and desirable. Extra thanks for doing the archaeology to find the PRs that made this no longer necessary. 😻 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Apr 26, 2024
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Excellent! I'm so glad to see this go away.
Member
|
Thanks again for noticing that this weird old code was no longer necessary! 😻 🦅 👁️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in [char.traits.specializations],
char_traits::assignshould just perform assignments. #1502 made these functions also start lifetime of elements since C++20, but this is possibly wrong as the difference is theoretically observable due to lack of constant evaluation failure. This PR reverts changes ofchar_traits::assign.Notes:
<xstring>: constexpr string element lifetime #3334 (and following-up PR Lifetime cleanups forbasic_string#4047) correctly madebasic_stringstart lifetime of elements when required.Edit: