Use requires-clauses and concepts for miscellaneous C++20/23 components
#4637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires-clause for miscellaneous C++20/23 componentsrequires-clauses and concepts for miscellaneous C++20/23 components
144729e to
5952e86
Compare
Notes: - Helper concepts are introduced to avoid constraints mismatch. - `is_same_v` is not replaced with `same_as` since the latter checks twice. - Containers, `tuple`, `pair`, and `zoned_time` are not yet touched. I think they should handled in concentrated following-up PRs.
5952e86 to
d5ac0b0
Compare
StephanTLavavej
approved these changes
May 15, 2024
Member
|
Thanks for the extremely careful work here - this is an excellent improvement and significantly improves readability! 😻 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for these awesome simplifications! 😸 🪄 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
is_same_vis not replaced withsame_assince the latter checks twice.tuple,pair, andzoned_timeare not yet touched. I think they should handled in concentrated following-up PRs.MSVC is buggy on detection of forming an invalid reference type to a cv-/ref-qualified function type in a
requires-expression. Reported DevCom-10648215.Towards #602.