Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Andor233
Copy link
Contributor

Fixes #4597

@Andor233 Andor233 requested a review from a team as a code owner May 13, 2024 13:24
@Andor233
Copy link
Contributor Author

@microsoft-github-policy-service agree

@frederick-vs-ja

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej added the bug Something isn't working label May 13, 2024
@StephanTLavavej StephanTLavavej self-assigned this May 13, 2024
@StephanTLavavej StephanTLavavej removed their assignment May 16, 2024
@StephanTLavavej
Copy link
Member

Thanks, this is awesome! 😻 I pushed a series of fine-grained commits to follow our coding conventions in the test, but nothing serious (beyond a bug number typo).

We merge changes to the GitHub and MSVC-internal repos simultaneously in a semi-manual process. To save time, we merge PRs in batches, and your PR will be part of the next batch. I'll post comments here as I prepare this (likely later this week although possibly next week if I get busy).

@Andor233
Copy link
Contributor Author

Thanks, this is awesome! 😻 I pushed a series of fine-grained commits to follow our coding conventions in the test, but nothing serious (beyond a bug number typo).

We merge changes to the GitHub and MSVC-internal repos simultaneously in a semi-manual process. To save time, we merge PRs in batches, and your PR will be part of the next batch. I'll post comments here as I prepare this (likely later this week although possibly next week if I get busy).

Thank you.

@StephanTLavavej StephanTLavavej self-assigned this May 17, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c8f45be into microsoft:main May 21, 2024
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug, and congratulations on your first microsoft/STL commit! 😻 πŸŽ‰ πŸͺ„

This change is expected to ship in VS 2022 17.11 Preview 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

<utility>: Side effects in self-swaps of pair are skipped

3 participants