Low-risk cleanups that I've been accumulating.

⚙️ Commits

• Comment: Fix alignment for _Is_word_table in <regex>.
• Comment: Drop extra space in P0088R3_variant_msvc.
• Uglify Enable => _Enable in <variant>.
• Use if constexpr for is_floating_point_v in <chrono>.
• Use if constexpr for is_base_of_v in P0220R1_sample.
• Comments: concept available => _HAS_CXX20 in <functional>.
• Add braces to _Idl_dist_add control flow in <algorithm>.
• Replace away the _NRAND macro in <random>.
  • Before constexpr all the generate_canonical parameters #2498 on 2022-02-07, the macro was #define _NRAND(eng, resty) (_STD generate_canonical<resty, static_cast<size_t>(-1)>(eng)) which avoided significant verbosity, but now it serves no purpose.
  • Replaced _NRAND\((\w+), (\w+)\) => _Nrand_impl<$2>($1) because surrounding parens were never necessary.
• Add const to unsigned int timeout in primitives.hpp.
• Change _Has_static_min_max from struct to constexpr bool in <random>.
  • Reverted, reported VSO-2417491 "C1XX /permissive- (strict mode) mishandles a variable template detecting static constexpr member functions", commented. (This isn't worth maintaining separate "workaround" / "no workaround" paths.)
• Drop unnecessary parens in P0355R7_calendars_and_time_zones_dates.
• Avoid unnecessary parens and += bool in VSO_0000000_vector_algorithms.
  • Directly adding a bool is weird, so we conventionally avoid that.
• Drop unnecessary typename in <format>.
• Extract an alias template _P_arg_type_t in <future>.
• _mm_mfence is SSE2; update comment after Build the x86 STL with /arch:SSE2 instead of /arch:IA32 #4741.
• Change unnecessary inline constexpr to constexpr for a function.
• while (true) => for (;;)
  • We traditionally used "for ever" to avoid "conditional expression is constant" warnings. While the compiler doesn't warn about true anymore, our usage remains consistent. (I don't feel super strongly about this one though.)
• Mark _HAS_STD_BYTE as // TRANSITION, OS-14273702.
  • Internal OS-14273702 has been active since 2017-10-17, but one can hope.
• _Name.length() => _Name.size() for string.
  • We're very particular about the synonym that we call.
• Fix comments: %[E0Q#] => %[EOQ#]
• Use braces to construct a temporary bitset.
  • When possible, we prefer braces to construct temporaries, since this avoids looking like a function call.
• util.py: executeCommandVerbose is dead.
• _AllocNode => _Alnode for consistency.
  • _Erase_tree_and_orphan_guard calls _Erase_tree_and_orphan, which already uses this naming convention:

    STL/stl/inc/xtree

    Lines 756 to 757 in 0d8f517

    	template <class _Alnode>
    	void _Erase_tree_and_orphan(_Alnode& _Al, _Nodeptr _Rootnode) noexcept {

  • As I always say, templates don't have a "type system" (especially without concepts), so naming is super important. This is an example of how avoiding unnecessary name changes between template layers is a good idea.