-
Notifications
You must be signed in to change notification settings - Fork 399
Refactor into a pnpm workspace #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- run: npm run build-all | ||
cache: 'pnpm' | ||
|
||
- run: pnpm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This awkwardly already runs build-all
.
I'd prefer it didn't, but our docs would need to be updated if that changes.
No, I want that to stay out of everyone's way.
I don't think it makes much of a difference, right? If we did this, would it work out of the box for anyone with Node 18+? Or would people have to run a command?
I can just run that manually I think. It doesn't need to be a script. |
Do you want me to convert that to
People still have to run
Right now there's no script or anything; you can technically leave the old specifiers in but pnpm won't help you update them everywhere as far as I know. |
npm run build | ||
git clone https://github.com/microsoft/TypeChat | ||
cd TypeChat | ||
pnpm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not everyone knows pnpm
, I'd recommend adding pnpm
install instructions (it could seem like a typo). https://pnpm.io/cli/install
Fixes #81
Outstanding questions:
build-all
onprepare
?site
be a part of the monorepo?build-all
build the site?changesets
.Theoretically I can attempt to do this via plain
npm
though @DanielRosenwasser had problems with it hence asking me to send this PR for real.