Auto import in angular typescript is not working #28773

micobarac · 2018-11-29T10:57:52Z

VSCode Version:
Version 1.29.1
Typescript 3.1.4
OS Version:
macOS 10.14.1

Steps to Reproduce:

Create new angular app:
ng new app
Add new library:
yarn add @datorama/akita
Create session.model.ts:

export interface Session {
  id: ID;
  firstName: string;
  lastName: string;
  token: string;
}

Auto import is not working. I get this error:

[ts] Cannot find name 'ID'. [2304]
any

Starting VSCode with code --disable-extensions didn't help :(

The text was updated successfully, but these errors were encountered:

mjbvz · 2018-11-29T19:27:14Z

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

micobarac · 2018-11-29T19:36:15Z

This happens with latest build both on macOS and Windows 10. A latest few builds, the autocomplete feels incosistent and partially working.

micobarac · 2018-11-29T19:37:59Z

I tried restarting the app, but no good.

micobarac · 2018-11-29T19:39:38Z

I haven't tried this insiders build. I am using the official final build.

mjbvz · 2018-11-29T19:42:02Z

Try on insiders

micobarac · 2018-11-29T21:35:35Z

I've just tried insiders version on Windows 10. The problem is still there. Auto import is not picking up the definition inside installed @datorama/akita package:

Cannot find name 'ID'.ts(2304)

It gets even weirder with rxjs package. Definitions from rxjs are offered for auto import, but the ones inside rxjs/operators like mapTo cannot be found.

The conclusion is that this auto import logic is obviously broken.

mjbvz · 2018-11-30T19:16:22Z

I confirmed this by using TS 3.3.0-dev20181130.

The index.d.ts from akita has export * from './api/types'; which has an ID type. I see this error after trying to open the api/types file directly:

Err 403   [11:12:21.819] Exception on executing command {"seq":65,"type":"request","command":"getApplicableRefactors","arguments":{"file":"/Users/matb/projects/san/node_modules/@datorama/akita/src/api/types.d.ts","startLine":1,"startOffset":1,"endLine":1,"endOffset":1}}:

    Could not find file: '/Users/matb/projects/san/node_modules/@datorama/akita/src/api/types.d.ts'.

    Error: Could not find file: '/Users/matb/projects/san/node_modules/@datorama/akita/src/api/types.d.ts'.
        at getValidSourceFile (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:117240:23)
        at Object.getApplicableRefactors (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:118017:24)
        at IOSession.Session.getApplicableRefactors (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:125638:53)
        at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:124512:61)
        at /Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:125857:88
        at IOSession.Session.executeWithRequestId (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:125848:28)
        at IOSession.Session.executeCommand (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:125857:33)
        at IOSession.Session.onMessage (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:125879:35)
        at Interface.<anonymous> (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:127139:27)
        at emitOne (events.js:116:13)
        at Interface.emit (events.js:211:7)
        at Interface._onLine (readline.js:282:10)
        at Interface._normalWrite (readline.js:424:12)
        at Socket.ondata (readline.js:141:10)
        at emitOne (events.js:116:13)
        at Socket.emit (events.js:211:7)
        at addChunk (_stream_readable.js:263:12)
        at readableAddChunk (_stream_readable.js:250:11)
        at Socket.Readable.push (_stream_readable.js:208:10)
        at Pipe.onread (net.js:594:20)

sheetalkamat · 2018-11-30T22:52:41Z

@mjbvz I don't get that exception. Note that when I create app and add that library it is not included in the project (because its not referenced from anywhere and hence completion wont show up for it as we only look for symbols in files included in the program). Opening the types.d.ts doesn't throw any expression. If I add import a from "@datorama/akita" to my test file, then it correctly shows ID in the completion list doing auto import if selected.

sheetalkamat · 2018-11-30T23:02:00Z

@mjbvz I am seeing the exceptions with that call stack when there is ordering mismatch in sending the requests from code-insiders. I was looking into #28389 this and I noticed that exception and log is:

Info 100  [14:57:17.992] request:
    {"seq":15,"type":"request","command":"close","arguments":{"file":"c:/temp/o2sql/lib/ast-translator.js"}}
Info 115  [14:57:17.992] request:
    {"seq":16,"type":"request","command":"getApplicableRefactors","arguments":{"file":"c:/temp/o2sql/lib/ast-translator.js","startLine":16,"startOffset":32,"endLine":16,"endOffset":32}}

And the log from vscode output window shows:

[Trace  - 2:56:34 PM] Sending request: close (15). Response expected: no. Current queue length: 1
Arguments: {
    "file": "c:/temp/o2sql/lib/ast-translator.js"
}
[Trace  - 2:56:34 PM] Sending request: getApplicableRefactors (16). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "c:/temp/o2sql/lib/ast-translator.js",
    "startLine": 16,
    "startOffset": 32,
    "endLine": 16,
    "endOffset": 32
}
[Trace  - 2:56:34 PM] TypeScript Server: trying to cancel ongoing request with sequence number 16

mjbvz · 2018-12-03T22:06:53Z

@sheetalkamat I can't repo the exception anymore on latest @next.

I still don't get quick fix though in a simple ts file though because @datorama/akita can't be resolved:

import a from '@datorama/akita'

ID;

tsserver.log

And shouldn't imports quick fixes pick up theID type from the module even without import?

sheetalkamat · 2018-12-04T00:27:37Z

@mjbvz the index.ts opened in inferred project and doesn't include @datorama/akita in its typings. I am not sure what configuration you are using but it seems like there is no tsconfig or jsconfig file.

Info 17   [14:2:53.142] For info: /Users/matb/projects/san/index.ts :: No config files found.

Info 32   [14:2:54.377] 	Files (21)
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es5.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2016.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.dom.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.dom.iterable.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.webworker.importscripts.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.scripthost.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.core.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.collection.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.generator.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.iterable.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.promise.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.proxy.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.reflect.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.symbol.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2016.array.include.d.ts
	/Users/matb/projects/san/node_modules/typescript/lib/lib.es2016.full.d.ts
	/Users/matb/projects/san/index.ts
	/Users/matb/projects/san/node_modules/@types/node/inspector.d.ts
	/Users/matb/projects/san/node_modules/@types/node/index.d.ts

mjbvz · 2018-12-04T00:41:52Z

Even once the import is resolved though, the quick fix still doesn't work for ID

sheetalkamat · 2018-12-04T18:26:50Z

Even once the import is resolved though, the quick fix still doesn't work for ID

The ID is type and not value. So it will work for

import a from '@datorama/akita'

const x : ID;

mjbvz · 2018-12-05T00:32:38Z

Man, i should stop trying to repo this bug; yes that was the issue.

Going back to the original repo steps:

Everything works for me on TS 3.2.1, provided you have a tsconfig (which ng should create)
Without a tsconfig, no quick fix. Most user are going to have a tsconfig but this seems like a bug to me

micobarac · 2018-12-06T07:53:04Z

The same problem occurs even when I try to import some Angular modules. For instance, if I want to autoimport OverlayModule from @angular/cdk, autoimport is not giving any suggestions either :(.

christopher-kiss · 2018-12-12T19:04:26Z

@mjbvz and @sheetalkamat

I'm having the same issue for Angular Material.

import { NgModule } from '@angular/core';

const modules = [MatButtonModule, MatToolbarModule, MatSidenavModule];

@NgModule({
    declarations: [],
    imports: modules,
    exports: modules,
    providers: []
})
export class MaterialModule {}

The suggestion for MatSidenavModule and the other 2 modules never show up, no light bulb either.

VS Code: 1.29.1 (system setup)
Typescript 3.1.6
Windows 10

micobarac · 2019-03-06T08:46:12Z

This is still not working, even with the latest VSCode version :(

sheetalkamat · 2019-07-18T21:21:01Z

@RyanCavanaugh @DanielRosenwasser This shouldn't be a bug but working as intended? WIthout the files being included in the project how can we know the symbol 'ID' is from @datorama/akita to offer it?

Let me know if we need to take any other action here. Thanks

smx-smx · 2019-09-16T19:47:54Z

Is it possible to force tsserver to lookup all files up-front?

If i'm using a lot of dependencies, or a large project with many dependencies, i would prefer to have tsserver scan all files up-front, so i don't have to find where every symbol is defined every time.

As a user, i could choose between

performance (i know where symbols are, i am going to do a few imports only)
completeness (i can accept an initial performance tradeoff to get more pertinent results)

I can see how doing this by default would make the process slower, so could this be an opt-in setting that forces tsserver to parse all files up-front eagerly? (user be warned: 'it will be slow', or something among those lines)

Thank you

vscodebot bot assigned mjbvz Nov 29, 2018

mjbvz transferred this issue from microsoft/vscode Nov 30, 2018

mjbvz removed their assignment Nov 30, 2018

weswigham added Bug A bug in TypeScript Domain: TSServer Issues related to the TSServer Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output labels Nov 30, 2018

weswigham added this to the TypeScript 3.2.2 milestone Nov 30, 2018

weswigham assigned sheetalkamat Nov 30, 2018

sheetalkamat added the Needs More Info The issue still hasn't been fully clarified label Nov 30, 2018

DanielRosenwasser modified the milestones: TypeScript 3.2.2, TypeScript 3.3.0 Dec 7, 2018

christopher-kiss mentioned this issue Dec 13, 2018

@angular/material no import suggestions #29009

Closed

sheetalkamat removed the Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output label Jan 16, 2019

sheetalkamat removed this from the TypeScript 3.3 milestone Jan 16, 2019

sheetalkamat added this to the TypeScript 3.4.0 milestone Jan 16, 2019

sheetalkamat mentioned this issue Jan 30, 2019

Auto import not working for lodash #29039

Closed

RyanCavanaugh modified the milestones: TypeScript 3.4.0, TypeScript 3.5.0 Mar 14, 2019

RyanCavanaugh removed the Needs More Info The issue still hasn't been fully clarified label Mar 14, 2019

RyanCavanaugh modified the milestones: TypeScript 3.5.0, TypeScript 3.6.0 Jun 12, 2019

sheetalkamat added Working as Intended The behavior described is the intended behavior; this is not a bug and removed Bug A bug in TypeScript labels Jul 18, 2019

sheetalkamat closed this as completed Jul 18, 2019

andrewbranch mentioned this issue Aug 23, 2019

Can't use auto import when node_modules are named "node_modules" #29629

Closed

andrewbranch mentioned this issue Sep 16, 2019

Global completion / Auto import for JavaScript symbols from modules without typings included. #33289

Closed

5 tasks

andrewbranch mentioned this issue Mar 4, 2020

VSCode intellisense not working with typescript 3.7.5 in Angular projects #37187

Closed

sheetalkamat mentioned this issue Mar 10, 2020

Rush's node_modules structure is not resolved in vscode correctly #28689

Closed

DanielRosenwasser mentioned this issue Apr 6, 2020

Expand auto-import to all dependencies in package.json #37812

Closed

DanielRosenwasser mentioned this issue Apr 27, 2020

Auto-imports from builder-util-runtime #38176

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto import in angular typescript is not working #28773

Auto import in angular typescript is not working #28773

micobarac commented Nov 29, 2018

mjbvz commented Nov 29, 2018

micobarac commented Nov 29, 2018

micobarac commented Nov 29, 2018

micobarac commented Nov 29, 2018 •

edited

Loading

mjbvz commented Nov 29, 2018

micobarac commented Nov 29, 2018 •

edited

Loading

mjbvz commented Nov 30, 2018

sheetalkamat commented Nov 30, 2018

sheetalkamat commented Nov 30, 2018 •

edited

Loading

mjbvz commented Dec 3, 2018

sheetalkamat commented Dec 4, 2018

mjbvz commented Dec 4, 2018

sheetalkamat commented Dec 4, 2018

mjbvz commented Dec 5, 2018 •

edited

Loading

micobarac commented Dec 6, 2018

christopher-kiss commented Dec 12, 2018 •

edited

Loading

micobarac commented Mar 6, 2019

sheetalkamat commented Jul 18, 2019 •

edited

Loading

smx-smx commented Sep 16, 2019

Auto import in angular typescript is not working #28773

Auto import in angular typescript is not working #28773

Comments

micobarac commented Nov 29, 2018

mjbvz commented Nov 29, 2018

micobarac commented Nov 29, 2018

micobarac commented Nov 29, 2018

micobarac commented Nov 29, 2018 • edited Loading

mjbvz commented Nov 29, 2018

micobarac commented Nov 29, 2018 • edited Loading

mjbvz commented Nov 30, 2018

sheetalkamat commented Nov 30, 2018

sheetalkamat commented Nov 30, 2018 • edited Loading

mjbvz commented Dec 3, 2018

sheetalkamat commented Dec 4, 2018

mjbvz commented Dec 4, 2018

sheetalkamat commented Dec 4, 2018

mjbvz commented Dec 5, 2018 • edited Loading

micobarac commented Dec 6, 2018

christopher-kiss commented Dec 12, 2018 • edited Loading

micobarac commented Mar 6, 2019

sheetalkamat commented Jul 18, 2019 • edited Loading

smx-smx commented Sep 16, 2019

micobarac commented Nov 29, 2018 •

edited

Loading

micobarac commented Nov 29, 2018 •

edited

Loading

sheetalkamat commented Nov 30, 2018 •

edited

Loading

mjbvz commented Dec 5, 2018 •

edited

Loading

christopher-kiss commented Dec 12, 2018 •

edited

Loading

sheetalkamat commented Jul 18, 2019 •

edited

Loading