Context flag for with statements to avoid parent pointer walks #17900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Andy-MS You have a similar change out that does a similar thing for the ambient context, do you have any opinions about this? |
|
Duplicate of #17721? |
|
@Andy-MS Absolutely a duplicate, closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
isInWithStatementBodyas a bailout condition all over the place in the checker - the most frequent places being at the top ofgetTypeOfNodeand insidegetContextualType. However it comes at a steep cost, as we are pretty much never within awithstatement body (they're not even valid syntax in strict mode), so we always walk all the way up to the containing source file.