Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Strict property initialization checks in classes #20075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 19 commits into from
Nov 20, 2017
Merged

Strict property initialization checks in classes #20075

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f1762a0
Attach return control flow graph to contructor declaration nodes
ahejlsberg Nov 16, 2017
5f6d7f3
Add strict property initialization checks
ahejlsberg Nov 16, 2017
c11969f
Mark returnFlowNode property as internal
ahejlsberg Nov 16, 2017
8cbff01
Add --strictPropertyInitialization compiler option
ahejlsberg Nov 16, 2017
3357aae
Update tests
ahejlsberg Nov 16, 2017
3a7a99f
Accept new baselines
ahejlsberg Nov 16, 2017
190f99e
Exclude static properties
ahejlsberg Nov 17, 2017
041d045
Revise return control flow graph construction logic
ahejlsberg Nov 17, 2017
4141a37
Add tests
ahejlsberg Nov 17, 2017
49d6ddf
Accept new baselines
ahejlsberg Nov 17, 2017
85ea473
Exclude abstract properties from strict initialization checks
ahejlsberg Nov 17, 2017
20b21d3
Add test
ahejlsberg Nov 17, 2017
6ba8c57
Accept new baselines
ahejlsberg Nov 17, 2017
86871c7
Fix lint error
ahejlsberg Nov 17, 2017
8c4c529
Merge branch 'master' into strictPropertyInitialization
ahejlsberg Nov 17, 2017
dccf57f
Simplify checkPropertyAccessExpressionOrQualifiedName
ahejlsberg Nov 18, 2017
0fbf36c
Add definite assignment checks for property accesses in constructor body
ahejlsberg Nov 18, 2017
82fd5a8
Add test
ahejlsberg Nov 18, 2017
87a8d41
Accept new baselines
ahejlsberg Nov 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Attach return control flow graph to contructor declaration nodes
  • Loading branch information
@ahejlsberg
ahejlsberg committed Nov 16, 2017
commit f1762a04ea736565ae0d988cc7a39de9e9d53d4b
7 changes: 6 additions & 1 deletion src/compiler/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,9 @@ namespace ts {
if (containerFlags & (ContainerFlags.IsFunctionExpression | ContainerFlags.IsObjectLiteralOrClassExpressionMethod)) {
(<FlowStart>currentFlow).container = <FunctionExpression | ArrowFunction | MethodDeclaration>node;
}
currentReturnTarget = undefined;
currentReturnTarget = node.kind === SyntaxKind.Constructor ? createBranchLabel() : undefined;
}
currentReturnTarget = isIIFE || node.kind === SyntaxKind.Constructor ? createBranchLabel() : undefined;
currentBreakTarget = undefined;
currentContinueTarget = undefined;
activeLabels = undefined;
Expand All @@ -535,6 +536,10 @@ namespace ts {
currentFlow = finishFlowLabel(currentReturnTarget);
}
else {
if (node.kind === SyntaxKind.Constructor) {
addAntecedent(currentReturnTarget, currentFlow);
(<ConstructorDeclaration>node).returnFlowNode = currentFlow;
}
currentFlow = saveCurrentFlow;
}
currentBreakTarget = saveBreakTarget;
Expand Down
1 change: 1 addition & 0 deletions src/compiler/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,7 @@ namespace ts {
kind: SyntaxKind.Constructor;
parent?: ClassDeclaration | ClassExpression;
body?: FunctionBody;
returnFlowNode?: FlowNode;
}

/** For when we encounter a semicolon in a class declaration. ES6 allows these as class elements. */
Expand Down